Remove references to s1053, use installdir instead #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rheacangeo
approved these changes
Dec 20, 2021
Contributor
rheacangeo
left a comment
There was a problem hiding this comment.
awesome, thanks for consolidating all those variables
rheacangeo
reviewed
Dec 20, 2021
.jenkins/install_virtualenv.sh
Outdated
| # check a virtualenv path has been provided | ||
| test -n "$1" || exitError 1001 ${virtualenv_path} "must pass an argument" | ||
| wheel_dir=/project/s1053/install/wheeldir | ||
| wheel_dir=${installdir}/wheeldir |
Contributor
There was a problem hiding this comment.
this might not be set if machineEnvironment is not run?
Contributor
There was a problem hiding this comment.
I think you might need a . ${BUILDENV_DIR}/machineEnvironment.sh in this script
Collaborator
Author
|
Launched performance plan https://jenkins.ginko.ch/job/pace-fv3core-performance-test-PR/19/ |
Collaborator
Author
|
Performance plan passed. Merging. |
mcgibbon
added a commit
to ai2cm/buildenv
that referenced
this pull request
Dec 21, 2021
twicki
pushed a commit
to twicki/pace
that referenced
this pull request
Aug 22, 2025
* Fix to get notebooks working in docker --------- Co-authored-by: Frank Malatino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR restores the "installdir" environment variable to machineEnvironment.sh in buildenv, and makes more consistent use of it inside our tests which make use of buildenv.
Depends on buildenv PR ai2cm/buildenv#33, ai2cm/buildenv#34.
Infrastructure changes:
/project/s1053/installon daint/project/s1053are removedChecklist
Before submitting this PR, please make sure:
Additionally, if this PR contains code authored by new contributors: