fix daint compilation #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r gt4py.<features>, otherwise on daint compilation breaks
mcgibbon
approved these changes
Feb 14, 2022
Collaborator
mcgibbon
left a comment
There was a problem hiding this comment.
Good job figuring this out, I can’t imagine it was easy.
Contributor
Author
|
launch jenkins |
twicki
pushed a commit
to twicki/pace
that referenced
this pull request
Aug 22, 2025
* removed direct gt4py imports * linting * added nametag to gtscript imports * linting * changed @function to @gtfunction * new NDSL version * new NDSL branch * new NDSL version, removing extra imports in ndsl.dsl.gt4py that causes crash during tests * new NDSL version... again * Added name to CONTRIBUTORS.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Reordering package imports in stencil.py so that pace.util loads after gt4py., otherwise on daint compilation breaks with
Field decl type <class 'gtc.gtir.FieldDecl'> has no 'dimensions' attributefrom the fv3core standalone.
Another solution that works is removing the imports from dsl/pace/dsl/init.py, but having those makes the driver cleaner to read.