Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix column integral dimension #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elynnwu merged 1 commit into from
Oct 17, 2022
Merged

Fix column integral dimension #358

elynnwu merged 1 commit into from
Oct 17, 2022

Conversation

@elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Oct 17, 2022

Purpose

Quick fix to diagnostics to better speicfy column integral dimension.

Code changes:

  • diagnostics: dims uses input quanity metadata

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

mcgibbon
mcgibbon approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@mcgibbon mcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elynnwu elynnwu enabled auto-merge (squash) October 17, 2022 18:34
@elynnwu elynnwu merged commit a6a3651 into main Oct 17, 2022
@elynnwu elynnwu deleted the fix/diag-quick-fix branch October 17, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcgibbon mcgibbon mcgibbon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elynnwu @mcgibbon