All storage temporaries are now Quantity #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdahm
reviewed
Nov 8, 2022
jdahm
reviewed
Nov 8, 2022
jdahm
approved these changes
Nov 9, 2022
twicki
reviewed
Nov 9, 2022
| data = allocator(shape, dtype=dtype) | ||
| return Quantity(data, dims=dims, units=units, origin=origin, extent=extent) | ||
|
|
||
| def get_quantity_halo_spec( |
Collaborator
Author
There was a problem hiding this comment.
Maybe, but it's only called on init, and would need a bit of extra logic because you can't LRU cache on a list (not hashable).
twicki
reviewed
Nov 9, 2022
| self.update_geopotential_height_on_c_grid( | ||
| self._zs, self._ut, self._vt, self._gz, self._ws3, dt2 | ||
| ) | ||
| # TODO (floriand): Due to DaCe VRAM pooling creating a memory |
Contributor
There was a problem hiding this comment.
this is solved, right? The fields are no longer used
Collaborator
Author
There was a problem hiding this comment.
self.cgrid_shallow_water_lagrangian_dynamics.ptc and self.cgrid_shallow_water_lagrangian_dynamics.delpc are used directly below. They used to be attached to this object instead of c_sw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR refactors all usage of storages to Quantity, other than in test code.
Code changes:
Checklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updated