Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add tuners #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 25, 2023
Merged

Add tuners #21

merged 10 commits into from
Jan 25, 2023

Conversation

@YamLyubov
Copy link
Collaborator

Main changes

  • SequentialTuner abstracted to general graph
  • PipelineTuner abstracted to general graph and renamed to SimultaniousTuner
  • SearchSpace abstracted to general graph
  • structure parameter added to Graph
  • parameters parameter added to LinkedGraphNode
  • ObjectiveEvaluate.eval_n_jobs made public to allow tuners to reset it

@YamLyubov YamLyubov requested a review from gkirgizov January 18, 2023 13:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023 •
edited
Loading

Codecov Report

Merging #21 (fab3517) into main (75dc6fb) will increase coverage by 1.02%.
The diff coverage is 92.41%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   74.28%   75.30%   +1.02%     
==========================================
  Files          90       94       +4     
  Lines        4829     5099     +270     
==========================================
+ Hits         3587     3840     +253     
- Misses       1242     1259      +17
Impacted Files Coverage Δ
...em/visualisation/opt_history/graphs_interactive.py 0.00% <0.00%> (ø)
golem/core/optimisers/objective/objective_eval.py 91.30% <83.33%> (-2.82%) ⬇️
golem/core/tuning/simultaneous.py 89.33% <89.33%> (ø)
golem/core/tuning/tuner_interface.py 91.02% <91.02%> (ø)
golem/core/dag/linked_graph_node.py 95.45% <92.30%> (+3.56%) ⬆️
golem/core/tuning/sequential.py 95.45% <95.45%> (ø)
golem/core/constants.py 100.00% <100.00%> (ø)
golem/core/dag/graph_utils.py 94.73% <100.00%> (+0.19%) ⬆️
golem/core/tuning/search_space.py 100.00% <100.00%> (ø)
golem/core/optimisers/timer.py 88.52% <0.00%> (+1.63%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

gkirgizov
gkirgizov requested changes Jan 19, 2023
View reviewed changes
@YamLyubov YamLyubov requested a review from gkirgizov January 24, 2023 10:43
@YamLyubov
Copy link
Collaborator Author

Еще перенесла изменения для тюнера из этого пр сюда

gkirgizov
gkirgizov requested changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@gkirgizov gkirgizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправь еще пару оставшихся комментариев

@YamLyubov YamLyubov requested a review from gkirgizov January 25, 2023 10:45
@YamLyubov YamLyubov merged commit 908f9ed into main Jan 25, 2023
@YamLyubov YamLyubov deleted the add-tuner branch January 25, 2023 12:07
@gkirgizov gkirgizov linked an issue Jan 26, 2023 that may be closed by this pull request
Tuner refactoring #27
Closed
6 tasks
@gkirgizov gkirgizov mentioned this pull request Jan 26, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkirgizov gkirgizov gkirgizov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tuner refactoring

4 participants

@YamLyubov @codecov-commenter @gkirgizov