Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix some issues #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 27, 2023
Merged

Fix some issues #230

merged 8 commits into from
Oct 27, 2023

Conversation

@kasyanovse
Copy link
Collaborator

  • Fix Problem with OptHistory #229
  • Fix Refactor utilities #173
  • Fix potential problem with n_jobs. It may appear if some multiprocessing modules cannot work with n_jobs < 0. Now n_jobs is checked and converted to positive value in GraphRequirements
  • Fix problem with retaining composing time calculation. Initial generation is taked as full generation, but it does not consume any time for preparing. Also fixed problem with generation num increment.

@kasyanovse kasyanovse linked an issue Oct 26, 2023 that may be closed by this pull request
Refactor utilities #173
Closed
@aim-pep8-bot
Copy link
Collaborator

Hello @kasyanovse! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 131:5: F631 assertion is always true, perhaps remove parentheses?
Line 132:5: F631 assertion is always true, perhaps remove parentheses?

@kasyanovse kasyanovse mentioned this pull request Oct 26, 2023
Merged
@maypink
Copy link
Collaborator

maypink commented Oct 27, 2023

поменяй плиз версию голема в этих файлах на 0.4.0
image

@maypink maypink requested review from YamLyubov and maypink October 27, 2023 09:23
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #230 (0c8ed59) into main (29cd362) will decrease coverage by 0.20%.
Report is 1 commits behind head on main.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   72.16%   71.96%   -0.20%     
==========================================
  Files         135      136       +1     
  Lines        8061     8130      +69     
==========================================
+ Hits         5817     5851      +34     
- Misses       2244     2279      +35
Files Coverage Δ
golem/core/adapter/adapt_registry.py 94.59% <100.00%> (ø)
golem/core/dag/graph_utils.py 97.29% <100.00%> (ø)
golem/core/dag/linked_graph.py 98.62% <100.00%> (ø)
golem/core/dag/linked_graph_node.py 97.61% <100.00%> (ø)
golem/core/log.py 89.34% <100.00%> (-1.64%) ⬇️
golem/core/optimisers/advisor.py 88.88% <100.00%> (ø)
golem/core/optimisers/fitness/fitness.py 86.90% <100.00%> (ø)
golem/core/optimisers/genetic/evaluation.py 94.00% <100.00%> (-0.38%) ⬇️
...ore/optimisers/genetic/operators/base_mutations.py 90.81% <100.00%> (ø)
...lem/core/optimisers/genetic/operators/crossover.py 92.78% <100.00%> (ø)
... and 27 more

... and 4 files with indirect coverage changes

maypink
maypink requested changes Oct 27, 2023
View reviewed changes
YamLyubov
YamLyubov reviewed Oct 27, 2023
View reviewed changes
@kasyanovse kasyanovse merged commit 52ad420 into main Oct 27, 2023
@kasyanovse kasyanovse deleted the 229-fix branch October 27, 2023 10:37
kasyanovse added a commit to aimclub/FEDOT that referenced this pull request Nov 1, 2023
@kasyanovse
Support for changes in GOLEM (#1189)
70fc033 
Add GOLEM 0.4.0 to requirements.
Fix imports from GOLEM (aimclub/GOLEM#230).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YamLyubov YamLyubov YamLyubov approved these changes

@maypink maypink maypink approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Problem with OptHistory Refactor utilities

6 participants

@kasyanovse @aim-pep8-bot @maypink @codecov-commenter @YamLyubov