Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@robpats
Copy link
Contributor

@robpats robpats commented Sep 7, 2025

What do these changes do?

Currently it is not possible to get the real progress of downloading data. The closest thing is `StreamReader.total_bytes, but it could be the number of bytes of decompressed data. This pull request addresses this.

Are there changes in behavior for the user?

A new property StreamReader.total_raw_bytes can be used by the user.

Is it a substantial burden for the maintainers to support this?

Related issue number

#11432

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES/ folder

@codecov
Copy link

codecov bot commented Sep 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.80%. Comparing base (6ae7c55) to head (7ecdff9).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11483   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files         127      127           
  Lines       43380    43413   +33     
  Branches     2326     2327    +1     
=======================================
+ Hits        42860    42893   +33     
  Misses        370      370           
  Partials      150      150           
Flag Coverage Δ
CI-GHA 98.67% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.41% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.73% <100.00%> (-0.01%) ⬇️
OS-macOS 97.62% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.14% <100.00%> (-0.01%) ⬇️
Py-3.10.18 97.64% <100.00%> (+<0.01%) ⬆️
Py-3.11.13 97.84% <100.00%> (+0.01%) ⬆️
Py-3.11.9 97.34% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.44% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.94% <100.00%> (+<0.01%) ⬆️
Py-3.13.7 98.19% <100.00%> (+<0.01%) ⬆️
Py-3.14.0-rc.3 98.14% <100.00%> (+0.01%) ⬆️
Py-3.14.0-rc.3t 97.20% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.9.23 97.53% <100.00%> (+<0.01%) ⬆️
Py-pypy3.9.19-7.3.16 89.52% <100.00%> (-0.83%) ⬇️
VM-macos 97.62% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.41% <100.00%> (+<0.01%) ⬆️
VM-windows 96.73% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 7, 2025

CodSpeed Performance Report

Merging #11483 will not alter performance

Comparing robpats:patch (7ecdff9) with master (6ae7c55)

Summary

✅ 59 untouched

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 7, 2025
@robpats robpats marked this pull request as ready for review September 7, 2025 07:12
@Dreamsorcerer Dreamsorcerer added the backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot label Sep 19, 2025
@Dreamsorcerer Dreamsorcerer merged commit 2c9dbad into aio-libs:master Oct 6, 2025
45 checks passed
@patchback
Copy link
Contributor

patchback bot commented Oct 6, 2025

Backport to 3.13: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 2c9dbad on top of patchback/backports/3.13/2c9dbad0542b928619109aba6e59dfa86d1457c4/pr-11483

Backporting merged PR #11483 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.13/2c9dbad0542b928619109aba6e59dfa86d1457c4/pr-11483 upstream/3.13
  4. Now, cherry-pick PR Add StreamReader.total_raw_bytes to report the download progress #11483 contents into that branch:
    $ git cherry-pick -x 2c9dbad0542b928619109aba6e59dfa86d1457c4
    If it'll yell at you with something like fatal: Commit 2c9dbad0542b928619109aba6e59dfa86d1457c4 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 2c9dbad0542b928619109aba6e59dfa86d1457c4
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Add StreamReader.total_raw_bytes to report the download progress #11483 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.13/2c9dbad0542b928619109aba6e59dfa86d1457c4/pr-11483
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Dreamsorcerer pushed a commit that referenced this pull request Oct 6, 2025
Dreamsorcerer added a commit that referenced this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants