-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add StreamReader.total_raw_bytes to report the download progress #11483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11483 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 127 127
Lines 43380 43413 +33
Branches 2326 2327 +1
=======================================
+ Hits 42860 42893 +33
Misses 370 370
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11483 will not alter performanceComparing Summary
|
Co-authored-by: Sam Bull <[email protected]>
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 2c9dbad on top of patchback/backports/3.13/2c9dbad0542b928619109aba6e59dfa86d1457c4/pr-11483 Backporting merged PR #11483 into master
🤖 @patchback |
) (cherry picked from commit 2c9dbad)
) (#11576) (cherry picked from commit 2c9dbad) Co-authored-by: robpats <[email protected]>
What do these changes do?
Currently it is not possible to get the real progress of downloading data. The closest thing is `StreamReader.total_bytes, but it could be the number of bytes of decompressed data. This pull request addresses this.
Are there changes in behavior for the user?
A new property
StreamReader.total_raw_bytescan be used by the user.Is it a substantial burden for the maintainers to support this?
Related issue number
#11432
Checklist
CONTRIBUTORS.txtCHANGES/folder