Feat: Use host header for proxy#745
Open
Chrisischris wants to merge 2 commits intoair-verse:masterfrom
Open
Conversation
|
I have exactly the same use case. The host should not be hardcoded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My app serves multiple subdomains so for local development I access it with sub1.localhost:port for example. Since the proxy has localhost hardcoded you couldn't use live reload with these urls, this new config allows you to use the host header when proxying the request. I've also added a config for number of retries before failing since apps can take longer than a second to build.