feat: add color flag #766
Open
feat: add color flag #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
suggested changes
May 1, 2025
main.go
Outdated
| flag.StringVar(&cfgPath, "c", "", "config path") | ||
| flag.BoolVar(&debugMode, "d", false, "debug mode") | ||
| flag.BoolVar(&showVersion, "v", false, "show version") | ||
| flag.BoolVar(&forceColor, "colored", false, "force colored output") |
There was a problem hiding this comment.
I would expect to be able to force color on or off via the CLI argument
Suggested change
| flag.BoolVar(&forceColor, "colored", false, "force colored output") | |
| flag.StringVar(&colorMode, "color", "auto", "colored output: auto, always, never") |
It's a common pattern with CLI tool.
I know NO_COLOR env can be used with fatih/color, but people could expect to disable color with CLI.
There was a problem hiding this comment.
I agree, thank you for the insight. As a web dev I don't have much experience creating/maintaining CLI tools
main.go
Outdated
Comment on lines
87
to
89
| if forceColor { | ||
| color.NoColor = false | ||
| } |
There was a problem hiding this comment.
So here, you can use
Suggested change
| if forceColor { | |
| color.NoColor = false | |
| } | |
| switch colorMode { | |
| case "always": | |
| color.NoColor = false | |
| case "never": | |
| color.NoColor = true | |
| case "auto", "": | |
| // do nothing | |
| default: | |
| log.Fatal("unsupported color mode: use always, never, auto") | |
| } |
ccoVeille
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a flag to force colored output, closes #417