Add configuration to keep the last successfully built binary when exiting with stop_on_error set #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When stop_on_error is true, the binary is always deleted. However, it can be useful to keep that around to speed up starting a new session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the config
stop_on_erroris set totrue, the built binary inbingets deleted after stoppingair.However, it can be useful to to keep the binary around when starting a new session of
airto not have to recompile it, where we'd like to stopairwith build errors (stop_on_error=true) but keep the latest built binary.But because
stop_on_error=falsebasically requires that the binary exists in order to work, this new configkeep_built_binaryis supplementary and only has effect ifstop_on_error=true.The new config is set to
falseby default to not create any breaking changes.Happy to discuss the approach, naming and so on, but hopefully the idea behind is clear.