Refactor ResolverTestBase #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ResolverTestBase` was implemented using the actual implementations of the various `ExecutionContext` interfaces. Since the construction of the actual implementations is entangled with the bootstrapping process, this made it difficult to initialize this test fixture, difficult to inject test data into the resolver tests that this class is meant to support, and difficult to change the implementation details of `ExecutionContext.`. This PR switches `ResolverTestBase` to use test doubles for `ExecutionContext`, decoupling it from the actual implementations of `ExecutionContext`. Github-Change-Id: 949532 GitOrigin-RevId: 1c0656a6793819a85c835c2bcc8b783331486de9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ResolverTestBasewas implemented using the actual implementations of the variousExecutionContextinterfaces. Since the construction of the actual implementations is entangled with the bootstrapping process, this made it difficult to initialize this test fixture, difficult to inject test data into the resolver tests that this class is meant to support, and difficult to change the implementation details ofExecutionContext.. This PR switchesResolverTestBaseto use test doubles forExecutionContext, decoupling it from the actual implementations ofExecutionContext.