Fix bug with lazy EODs resolving twice #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the client query includes a node, and a resolver RSS also includes the same node in the same OER (same path from the root query), we attempt to call `resolveData` on the lazyeod twice, which ends up calling the node resolver twice. This also results in OER.resolve() throwing since it's already been resolved. This fixes this bug, and also migrates NodeResolverTest from the old to the new engine feature test framework so I can add a test case there. Github-Change-Id: 951240 GitOrigin-RevId: ac6e62c630c899e7468bfca9f8069252d9bbb12f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the client query includes a node, and a resolver RSS also includes the same node in the same OER (same path from the root query), we attempt to call
resolveDataon the lazyeod twice, which ends up calling the node resolver twice. This also results in OER.resolve() throwing since it's already been resolved. This fixes this bug, and also migrates NodeResolverTest from the old to the new engine feature test framework so I can add a test case there.