[Docs] - add corr_interactive_plot example #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akanz1
previously approved these changes
Jul 26, 2023
Owner
akanz1
left a comment
There was a problem hiding this comment.
Great, thank you for the update. I leave it up to you to decide about the colors, whichever you think is more suitable. I'll run and test everything before creating a release so if it bothers me then i can still make a change :)
Contributor
Author
|
I've fixed the colors and updated the |
|
Kudos, SonarCloud Quality Gate passed!
|
akanz1
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will add an example of
corr_interactive_plotinreadme.mdand/examplesdirectories.After posting this example, I noticed one thing: when the user sets the
splitvalues with"pos"or"neg"the usual method to calculate the color scale plots different colors compared tocorr_plot, this is a problem? If it's an issue, I can add the following code after calculating vmax and vmin incorr_interactive_plot:This fix should address the color problem.