Thanks to visit codestin.com
Credit goes to github.com

Skip to content

release v1.0.0 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akanz1 merged 8 commits into from
Jan 16, 2022
Merged

release v1.0.0 #23

akanz1 merged 8 commits into from
Jan 16, 2022

Conversation

@akanz1
Copy link
Owner

@akanz1 akanz1 commented Jan 16, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 16, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 10.69%.

Quality metrics Before After Change
Complexity 3.72 ⭐ 5.66 ⭐ 1.94 👎
Method Length 68.91 🙂 128.70 😞 59.79 👎
Working memory 12.79 😞 15.59 ⛔ 2.80 👎
Quality 61.38% 🙂 50.69% 🙂 -10.69% 👎
Other metrics Before After Change
Lines 988 577 -411
Changed files Quality Before Quality After Quality Change
src/klib/init.py 86.54% ⭐ 88.01% ⭐ 1.47% 👍
src/klib/clean.py 56.82% 🙂 50.10% 🙂 -6.72% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/klib/clean.py clean_column_names 10 🙂 352 ⛔ 34 ⛔ 26.20% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/clean.py pool_duplicate_subsets 8 ⭐ 228 ⛔ 13 😞 43.45% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/clean.py mv_col_handling 7 ⭐ 193 😞 14 😞 45.44% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/clean.py data_cleaning 3 ⭐ 144 😞 16 ⛔ 51.58% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/klib/clean.py drop_missing 1 ⭐ 116 🙂 12 😞 62.26% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 16, 2022 •
edited
Loading

Codecov Report

Merging #23 (660b1d8) into main (94fa1c1) will decrease coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   51.01%   50.00%   -1.02%     
==========================================
  Files           4        3       -1     
  Lines         541      444      -97     
  Branches       72       63       -9     
==========================================
- Hits          276      222      -54     
+ Misses        255      212      -43     
  Partials       10       10
Impacted Files Coverage Δ
src/klib/clean.py 78.94% <ø> (+12.84%) ⬆️
src/klib/utils.py 93.25% <0.00%> (-2.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94fa1c1...660b1d8. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jan 16, 2022

This pull request fixes 1 alert when merging 660b1d8 into 94fa1c1 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@akanz1 akanz1 merged commit 4190f78 into main Jan 16, 2022
@akanz1 akanz1 deleted the develop branch January 16, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akanz1