Thanks to visit codestin.com
Credit goes to github.com

Skip to content

types and updates #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akanz1 merged 13 commits into from
Jul 31, 2022
Merged

types and updates #27

akanz1 merged 13 commits into from
Jul 31, 2022

Conversation

@akanz1
Copy link
Owner

@akanz1 akanz1 commented Jul 29, 2022 •
edited
Loading

  • add some more tests
  • check that plots work still as expected
  • update and check types
  • remove some type errors
  • update packages

@akanz1 akanz1 linked an issue Jul 29, 2022 that may be closed by this pull request
Update type hints using py3.9 or 3.10 #13
Closed
@akanz1 akanz1 self-assigned this Jul 29, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jul 29, 2022 •
edited
Loading

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.38%.

Quality metrics Before After Change
Complexity 4.79 ⭐ 4.67 ⭐ -0.12 👍
Method Length 121.98 😞 121.06 😞 -0.92 👍
Working memory 11.45 😞 11.12 😞 -0.33 👍
Quality 56.09% 🙂 57.47% 🙂 1.38% 👍
Other metrics Before After Change
Lines 2167 2185 18
Changed files Quality Before Quality After Quality Change
src/klib/init.py 79.33% ⭐ 85.39% ⭐ 6.06% 👍
src/klib/_version.py 100.00% ⭐ 100.00% ⭐ 0.00%
src/klib/clean.py 48.96% 😞 49.25% 😞 0.29% 👍
src/klib/describe.py 32.92% 😞 32.94% 😞 0.02% 👍
src/klib/utils.py 61.70% 🙂 70.72% 🙂 9.02% 👍
src/klib/scripts/performance.py 81.27% ⭐ 81.27% ⭐ 0.00%
tests/test_clean.py 75.23% ⭐ 74.30% 🙂 -0.93% 👎
tests/test_util.py 88.66% ⭐ 88.66% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/klib/describe.py cat_plot 13 🙂 679 ⛔ 21 ⛔ 24.58% ⛔ Try splitting into smaller methods. Extract out complex expressions
src/klib/clean.py clean_column_names 10 🙂 455 ⛔ 32 ⛔ 25.03% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py missingval_plot 6 ⭐ 821 ⛔ 19 ⛔ 32.20% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py dist_plot 9 🙂 797 ⛔ 15 😞 33.10% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py corr_plot 2 ⭐ 269 ⛔ 22 ⛔ 39.03% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sourcery-ai sourcery-ai bot mentioned this pull request Jul 29, 2022
Merged
@codecov
Copy link

codecov bot commented Jul 29, 2022 •
edited
Loading

Codecov Report

Merging #27 (f276f0e) into main (7b7d022) will increase coverage by 2.62%.
The diff coverage is 95.31%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   50.00%   52.62%   +2.62%     
==========================================
  Files           3        3              
  Lines         444      458      +14     
  Branches       63       61       -2     
==========================================
+ Hits          222      241      +19     
+ Misses        212      210       -2     
+ Partials       10        7       -3
Impacted Files Coverage Δ
src/klib/describe.py 18.96% <87.50%> (+3.65%) ⬆️
src/klib/clean.py 82.83% <94.11%> (+3.88%) ⬆️
src/klib/utils.py 93.47% <100.00%> (+0.21%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2022

This pull request fixes 1 alert when merging 7ff4f06 into 7b7d022 - view on LGTM.com

fixed alerts:

  • 1 for Unhashable object hashed

@lgtm-com
Copy link

lgtm-com bot commented Jul 30, 2022

This pull request fixes 1 alert when merging 44f3a7e into 7b7d022 - view on LGTM.com

fixed alerts:

  • 1 for Unhashable object hashed

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2022

This pull request fixes 1 alert when merging fed671c into 7b7d022 - view on LGTM.com

fixed alerts:

  • 1 for Unhashable object hashed

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Jul 31, 2022

This pull request fixes 1 alert when merging f276f0e into 7b7d022 - view on LGTM.com

fixed alerts:

  • 1 for Unhashable object hashed

@akanz1 akanz1 merged commit 0ccad79 into main Jul 31, 2022
@akanz1 akanz1 deleted the 13-update-type-hints-using-py39-or-310 branch July 31, 2022 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@akanz1 akanz1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update type hints using py3.9 or 3.10

2 participants

@akanz1