Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prep release #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akanz1 merged 22 commits into from
Aug 27, 2022
Merged

Prep release #30

akanz1 merged 22 commits into from
Aug 27, 2022

Conversation

@akanz1
Copy link
Owner

@akanz1 akanz1 commented Aug 27, 2022

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Aug 27, 2022 •
edited
Loading

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 4.34 ⭐ 4.35 ⭐ 0.01 👎
Method Length 123.38 😞 124.17 😞 0.79 👎
Working memory 10.55 😞 10.52 😞 -0.03 👍
Quality 59.14% 🙂 59.09% 🙂 -0.05% 👎
Other metrics Before After Change
Lines 2374 2381 7
Changed files Quality Before Quality After Quality Change
docs/old/source/conf.py 90.75% ⭐ 90.75% ⭐ 0.00%
docs/site/old/source/conf.py 90.75% ⭐ 90.75% ⭐ 0.00%
src/klib/clean.py 49.18% 😞 49.26% 😞 0.08% 👍
src/klib/describe.py 32.92% 😞 32.92% 😞 0.00%
src/klib/utils.py 70.61% 🙂 70.61% 🙂 0.00%
src/klib/scripts/performance.py 81.11% ⭐ 81.11% ⭐ 0.00%
tests/test_clean.py 74.20% 🙂 72.80% 🙂 -1.40% 👎
tests/test_describe.py 75.19% ⭐ 75.19% ⭐ 0.00%
tests/test_util.py 88.51% ⭐ 88.51% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/klib/describe.py cat_plot 13 🙂 680 ⛔ 21 ⛔ 24.58% ⛔ Try splitting into smaller methods. Extract out complex expressions
src/klib/clean.py clean_column_names 10 🙂 456 ⛔ 32 ⛔ 25.02% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py missingval_plot 6 ⭐ 822 ⛔ 19 ⛔ 32.20% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py dist_plot 9 🙂 798 ⛔ 15 😞 33.10% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py corr_plot 2 ⭐ 270 ⛔ 22 ⛔ 38.99% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Aug 27, 2022 •
edited
Loading

Codecov Report

Merging #30 (e93b222) into main (0ccad79) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   52.62%   52.62%           
=======================================
  Files           3        3           
  Lines         458      458           
  Branches       61       61           
=======================================
  Hits          241      241           
  Misses        210      210           
  Partials        7        7
Impacted Files Coverage Δ
src/klib/clean.py 82.83% <ø> (ø)
src/klib/utils.py 93.47% <ø> (ø)
src/klib/describe.py 18.96% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akanz1 akanz1 merged commit eddc9ed into main Aug 27, 2022
@akanz1 akanz1 deleted the prep-release branch September 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akanz1