Prevent excluded columns to be dropped #31
Conversation
Single value columns drop the excluded columns anyway, this prevent the process to remove the column even if they are single value and they are on the excluded columns.
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.17%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Good point, thank you for your contribution @jrrmcalcio! If you like you can add a small test checking that single_val_cols are kept now if they are in the exclusions, otherwise i'll do that likely later this week when i release a new version. |
Single value columns drop the excluded columns anyway, this prevent the process to remove the column even if they are single value and they are on the excluded columns.