Thanks to visit codestin.com
Credit goes to github.com

Skip to content

improve stats summary in cat_plot #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akanz1 merged 2 commits into from
Sep 23, 2022
Merged

improve stats summary in cat_plot #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2d19d1
improve stats summary in cat_plot
hasan-alper Sep 22, 2022
925ac98
linting + simplify
akanz1 Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/klib/describe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
import pandas as pd
import scipy
import seaborn as sns
from matplotlib import ticker
from matplotlib.colors import LinearSegmentedColormap
from matplotlib.colors import to_rgb

from klib.utils import _corr_selector
from klib.utils import _missing_vals
from klib.utils import _validate_input_bool
Expand All @@ -23,9 +27,6 @@
from klib.utils import _validate_input_range
from klib.utils import _validate_input_smaller
from klib.utils import _validate_input_sum_larger
from matplotlib import ticker
from matplotlib.colors import LinearSegmentedColormap
from matplotlib.colors import to_rgb

__all__ = ["cat_plot", "corr_mat", "corr_plot", "dist_plot", "missingval_plot"]

Expand Down Expand Up @@ -92,15 +93,16 @@ def cat_plot(
lim_top, lim_bot = top, bottom

if n_unique < top + bottom:
lim_top = int(n_unique // 2)
lim_bot = int(n_unique // 2) + 1

if n_unique <= 2:
lim_top = lim_bot = int(n_unique // 2)
if bottom > top:
lim_top = min(int(n_unique // 2), top)
lim_bot = n_unique - lim_top
else:
lim_bot = min(int(n_unique // 2), bottom)
lim_top = n_unique - lim_bot

value_counts_top = value_counts[:lim_top]
value_counts_idx_top = value_counts_top.index.tolist()
value_counts_bot = value_counts[-lim_bot:]
value_counts_bot = value_counts[-lim_bot:] if lim_bot > 0 else pd.DataFrame()
value_counts_idx_bot = value_counts_bot.index.tolist()

if top == 0:
Expand Down