Delete inappropriate validation in klib.catplot() #71
Conversation
Delete Validation in klib.displot() top, bottom is bins number to be visualized for each column . data.shape[1] is column amount. for each column 0<top<column.unique is more logical. (But this validation is also not neccessary)
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.11%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Will verify in the next days and draft a release, thanks for reporting @px39n |
Codecov Report
@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 53.31% 53.54% +0.22%
==========================================
Files 3 3
Lines 467 465 -2
Branches 63 63
==========================================
Hits 249 249
+ Misses 211 209 -2
Partials 7 7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Delete inappropriate Validation in klib.catplot()
top, bottom: is bins number to be visualized for each column.
But data.shape[1] = Total column amount.
In the original code, the validation check is to make
This is not logical.
I think you may intend to check boundary for bin number:
(But the bin number is already adaptive adjusted, see variable top_lim)
So please delete these two lines, or otherwise, eg
when we have a table with 5 column. and we want to set top=6, bop=3.
Error will be raised.