Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[BUG] - fix bug in missingval_plot #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
akanz1 merged 1 commit into from
Nov 12, 2022
Merged

[BUG] - fix bug in missingval_plot #73

akanz1 merged 1 commit into from
Nov 12, 2022

Conversation

@akanz1
Copy link
Owner

@akanz1 akanz1 commented Nov 12, 2022 •
edited
Loading

Fixes #68

unclear which version of matplotlib introduced this change but rotation has to be specified as an integer now.

@akanz1 akanz1 self-assigned this Nov 12, 2022
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 12, 2022

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 9.79 🙂 9.79 🙂 0.00
Method Length 481.17 ⛔ 481.17 ⛔ 0.00
Working memory 16.89 ⛔ 16.89 ⛔ 0.00
Quality 31.99% 😞 31.99% 😞 0.00%
Other metrics Before After Change
Lines 774 774 0
Changed files Quality Before Quality After Quality Change
src/klib/describe.py 31.99% 😞 31.99% 😞 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/klib/describe.py cat_plot 17 🙂 672 ⛔ 21 ⛔ 21.30% ⛔ Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py missingval_plot 6 ⭐ 822 ⛔ 19 ⛔ 32.20% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py dist_plot 9 🙂 798 ⛔ 15 😞 33.10% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py corr_plot 2 ⭐ 270 ⛔ 22 ⛔ 38.99% 😞 Try splitting into smaller methods. Extract out complex expressions
src/klib/describe.py corr_mat 8 ⭐ 199 😞 51.35% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@akanz1 akanz1 added the bug Something isn't working label Nov 12, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@akanz1 akanz1 marked this pull request as ready for review November 12, 2022 07:43
@akanz1 akanz1 changed the title [BUG] - missinval_plot method return ValueError [BUG] - fix bug in missingval_plot Nov 12, 2022
@codecov
Copy link

codecov bot commented Nov 12, 2022 •
edited
Loading

Codecov Report

Merging #73 (f62c392) into main (d6d9480) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   53.54%   53.54%           
=======================================
  Files           3        3           
  Lines         465      465           
  Branches       63       63           
=======================================
  Hits          249      249           
  Misses        209      209           
  Partials        7        7
Impacted Files Coverage Δ
src/klib/describe.py 19.74% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@akanz1 akanz1 merged commit 086f61a into main Nov 12, 2022
@akanz1 akanz1 deleted the akanz1/issue68 branch November 12, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@akanz1 akanz1

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] - missinval_plot method return ValueError

2 participants

@akanz1