Allow to configure whether or not connections are bidirectional #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only bidirectional connections were supported. This was achieved by adding them to both hosts at the same time when the NetworkInterface connected. In some cases, we have fully-independent up- and downlink channels (or only one of them), which cannot be simulated accurately with the default behavior. This adds a configuration parameter "bidirectionalConnections" on a per-interface basis, which allows to enable unidirectional connections (by setting the parameter to false). This also removes the check from ActiveRouter.checkReceiving whether the current router is "transferring". This check is redundant because the outgoing connection is already checked beforehand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only bidirectional connections were supported. This was
achieved by adding them to both hosts at the same time when the
NetworkInterface connected. In some cases, we have fully-independent up-
and downlink channels (or only one of them), which cannot be
simulated accurately with the default behavior.
This adds a configuration parameter "bidirectionalConnections" on a
per-interface basis, which allows to enable unidirectional connections
(by setting the parameter to false).
This also removes the check from ActiveRouter.checkReceiving whether the
current router is "transferring". This check is redundant because the
outgoing connection is already checked beforehand.