Adapt public API's to accept either typed or classic systems #900
Conversation
| case m => scala.concurrent.Future.failed(new NotImplementedError(s"Not implemented: $m")) | ||
| }) | ||
| .recoverWith(GrpcExceptionHandler.from(eHandler(system))(system, writer)) | ||
| .recoverWith(GrpcExceptionHandler.from(eHandler(system.classicSystem))(system, writer)) |
There was a problem hiding this comment.
@raboof if I understand well, users willing to bump to akka-grpc 0.8.3 with an akka 2.6.x classpath (in my case brought by Play 2.8.1) need to wait for akka 2.6.5 to come out with akka/akka-core#28847 and manually declare it, right?
There was a problem hiding this comment.
Ach, you are right of course. This change in Akka is binary compatible, but not source compatible. Since we're generating sources here that impacts us.
Until 2.6.5 is out we can work around it in Akka gRPC by moving the conversion from the generated code to the akka-grpc-runtime library.
Do you want to or shall I?
There was a problem hiding this comment.
That's what I experienced this morning, generated code doesn't compile when using akka-grpc 0.8.3 with akka 2.6.4
There was a problem hiding this comment.
Until 2.6.5 is out we can work around it in Akka gRPC by moving the conversion from the generated code to the akka-grpc-runtime library.
Makes sense! I'm AFK today, so I won't get the chance to look at it.
I don't have an urgent need for this, so my question was more related to how forcing 2.6.5+, when available, would have been possible without the client adding it manually (since akka-grpc brings 2.5.x until 1.x from what I understand). But if we move the accessor to the right package, this becomes unnecessary obviously.
This is part of #761 but does not close the issue entirely