fix(git): gsync compatibility #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add bash 5.x to Brewfile (macOS ships with 3.2) - Update gsync shebang to use env bash (respects PATH) - Use --if-present for optional build/test scripts - Fix terminology: 'unpushed' → 'unmerged' commits
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of the gsync script by making pnpm build and test commands conditional. Previously, the script would fail if a project didn't have build or test scripts defined in package.json. The changes use pnpm's --if-present flag to gracefully skip these commands when they're not available, making gsync compatible with a wider range of pnpm projects.
- Updated pnpm command execution to conditionally run build and test scripts
- Improved user feedback by separating install/build/test steps with clearer messaging
- Added a changeset documenting the compatibility improvement
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bin/gsync | Modified pnpm command execution to use --if-present flag for conditional build/test script execution, improving compatibility with projects that don't define these scripts |
| .changeset/cuddly-laws-watch.md | Added changeset file documenting the patch-level compatibility improvement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a patch-level update to improve
gsynccompatibility in thetk-dotfilesproject.gsyncto ensure smoother integration. (.changeset/cuddly-laws-watch.md)