Tox tests pass, though it looks like 3.10 was skipped:

  py313: OK (7.82=setup[6.96]+cmd[0.86] seconds)                                                                                                                                          
  py312: OK (3.62=setup[2.84]+cmd[0.77] seconds)                                             
  py311: OK (5.48=setup[4.32]+cmd[1.16] seconds)                                                                                                                                          
  py310: SKIP (0.45 seconds)                                                                 
  py39: OK (6.78=setup[5.52]+cmd[1.26] seconds)                                              
  congratulations :) (24.16 seconds)   

@hslabbert thanks for the PR, a few quick notes after a first look:

• there are quite a few whitespace and formatting changes that make it hard to review. could you pls clean those up?
• the .gitignore addition, was that for local testing?
• what’s the reason for the change in interface_ds.py?
• the PR should update secret.yaml to include the new option

Hey,

here are quite a few whitespace and formatting changes that make it hard to review. could you pls clean those up?

Yea, sorry. My editor is set to trimming trailing whitespace on save so ended up with that on updating README.md. Apologies for not picking that out to start. I'll turn that off for the project and fix.

the .gitignore addition, was that for local testing?

Yes, for running the code with config, to not have router creds in there. That seems like a sensible addition to .gitignore, except where I had a leading / on one but not the other. I can strip that out if it's not helpful, though.

what’s the reason for the change in interface_ds.py?

Unlike for Ethernet etc interfaces, the /interfaces/w60g devices don't include the name in their monitor output (ref #217 (comment) for example output). I hoped to avoid touching the DS directly, but that seemed the only place I could add conditional logic to fetch the name from the enumerate(interfaces) output if it or the comment cannot be retrieved from the existing stanza.

the PR should update secret.yaml to include the new option

Ah, right. Sorry, I wasn't aware of that one.

I'll adjust and submit updates to the PR.

Okay, I think I have those all addressed, with the only piece remaining being that interface_ds.py to pull in the name that's missing from the interfaces/w60g monitor output.

@hslabbert OK thanks, looks good. The only suggestion regarding interface_ds.py, might be a bit tidier to replace the elif block with something like that:

interface_monitor_record.setdefault('name', interface['name'])