Update bincode requirement from 1 to 2 #33
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [bincode](https://github.com/bincode-org/bincode) to permit the latest version. - [Release notes](https://github.com/bincode-org/bincode/releases) - [Commits](bincode-org/bincode@v1.0.0...v2.0.0) --- updated-dependencies: - dependency-name: bincode dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
imlk0
added a commit
to inclavare-containers/serf
that referenced
this pull request
Dec 2, 2025
The example `toyconsul` fails to compile due to the use of deprecated `bincode::serialize` and `bincode::deserialize` when upgrading to bincode 2.x with the `serde` feature enabled. This commit: - Updates `Cargo.toml` to enable the `serde` feature for bincode. - Replaces deprecated `serialize`/`deserialize` calls with the new `bincode::serde::encode_to_vec` and `decode_from_slice` APIs. - Adjusts result handling to account for the tuple return `(T, usize)` from `decode_from_slice`. Fixes build breakage introduced by al8n#33. Signed-off-by: Kun Lai <[email protected]>
al8n
pushed a commit
that referenced
this pull request
Dec 2, 2025
* fix: remove unused variable `encoded_len` warning when metrics feature is disabled Signed-off-by: Kun Lai <[email protected]> * fix(toyconsul): fix compilation error after bincode update in #33 The example `toyconsul` fails to compile due to the use of deprecated `bincode::serialize` and `bincode::deserialize` when upgrading to bincode 2.x with the `serde` feature enabled. This commit: - Updates `Cargo.toml` to enable the `serde` feature for bincode. - Replaces deprecated `serialize`/`deserialize` calls with the new `bincode::serde::encode_to_vec` and `decode_from_slice` APIs. - Adjusts result handling to account for the tuple return `(T, usize)` from `decode_from_slice`. Fixes build breakage introduced by #33. Signed-off-by: Kun Lai <[email protected]> * fix(toyconsul): fix 100% CPU spin on Ctrl+C by handling closed event channel Gracefully break event loop when serf event channel is closed during shutdown, preventing busy-loop caused by ignored recv() errors. Signed-off-by: Kun Lai <[email protected]> * fix: suppress unused variable warning for `msg` in delegate.rs Move the loop inside `#[cfg(feature = "metrics")]` block and rename `msg` to `_msg` to explicitly indicate it's intentionally unused when metrics are disabled. Signed-off-by: Kun Lai <[email protected]> * fix: break cycle between SerfDelegate and KeyManager using weak references Previously, a reference cycle existed: - `Serf` → strongly owns → `SerfDelegate` and `KeyManager` - `SerfDelegate` and `KeyManager` → each hold a strong `OnceLock<Serf<T, D>>` → back to `Serf` Which prevented `Drop` from running and caused memory leaks. This commit: - Introduces `SerfWeakRef<T, D>` to allow holding a weak reference to `Serf`. - Changes `OnceLock<Serf<T, D>>` in delegate and key manager to `OnceLock<SerfWeakRef<T, D>>`. - Uses `downgrade()` when storing the serf instance during initialization. - Safely upgrades to strong reference only when needed, and handles `None` gracefully. Now the object graph can be properly dropped on shutdown, fixing memory leaks and ensuring `Drop` hooks run. Signed-off-by: Kun Lai <[email protected]> --------- Signed-off-by: Kun Lai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on bincode to permit the latest version.
Release notes
Sourced from bincode's releases.
... (truncated)
Commits
a3381092.0.0 stable (#742)c8a42f7Decode context (#749)56da696make serde decode api consistent (#748)1332236Expose types implementingserde::SerializerandDeserializer(#729)d8baf43Finally got around to updating the spec based on feedback (#741)75b2928Document making serde an optional dependency (#746)5727e67Fix CI and clippy (#747)0ab1f71chore typo fix README.md (#737)29d8d84impl basic traits forCompatandBorrowCompat(#734)330e277Fix typo in spec.md (#730)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)