-
Notifications
You must be signed in to change notification settings - Fork 54
Add a tutorial section #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 28 28
Lines 1895 1895
Branches 407 407
=======================================
Hits 1873 1873
Misses 2 2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, I am just making small edits and add a bit more content to workflows (copied and shortened from docs).
- add ABFE example - make link names more expressive - fixed issue/PR ref in CHANGELOG
|
@ryankzhu would you like to review the added tutorial? The built docs are at https://alchemlyb--379.org.readthedocs.build/en/379/tutorial.html |
|
@xiki-tempula let's wait with merging for at least 2 days to give our JOSS reviewers a chance to look at it and ask for changes. |
|
Thank you for adding the tutorial section to the docs! The tutorial looks good to me. |
Fix #382
See openjournals/joss-reviews#6934 :