Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Correct the old style logging. #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 8, 2023
Merged

Correct the old style logging. #324

merged 3 commits into from
Jun 8, 2023

Conversation

@xiki-tempula
Copy link
Collaborator

@xiki-tempula xiki-tempula commented Jun 7, 2023 •
edited
Loading

Fix #323

@xiki-tempula xiki-tempula linked an issue Jun 7, 2023 that may be closed by this pull request
Correct some logging messages #323
Closed
@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #324 (673c5c6) into master (ae7f40b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          27       27           
  Lines        1767     1767           
  Branches      389      389           
=======================================
  Hits         1745     1745           
  Misses          2        2           
  Partials       20       20
Impacted Files Coverage Δ
src/alchemlyb/visualisation/dF_state.py 95.83% <ø> (ø)
src/alchemlyb/visualisation/ti_dhdl.py 100.00% <ø> (ø)
src/alchemlyb/parsing/amber.py 99.15% <100.00%> (ø)
src/alchemlyb/visualisation/convergence.py 100.00% <100.00%> (ø)
src/alchemlyb/workflows/abfe.py 99.67% <100.00%> (ø)

@xiki-tempula xiki-tempula marked this pull request as ready for review June 8, 2023 15:45
@xiki-tempula xiki-tempula requested a review from orbeckst June 8, 2023 15:45
orbeckst
orbeckst approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. I think you caught all of them. (Presumably you also did git grep % src/ to find all?)

@orbeckst orbeckst merged commit 4c3308c into master Jun 8, 2023
@orbeckst orbeckst deleted the 323-correct-some-logging-messages branch June 8, 2023 16:08
@xiki-tempula
Copy link
Collaborator Author

I tried to find all the % in src using the find in files function of pycharm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correct some logging messages

3 participants

@xiki-tempula @orbeckst