update type hinting #441
Merged
update type hinting #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local type checker mypy src alchemlyb is happy again.
orbeckst
commented
Oct 21, 2025
| ] | ||
| initial_f_k = pd.Series( | ||
| [ | ||
| initial_f_k.loc(x) if x in states else np.nan |
There was a problem hiding this comment.
Not really sure how loc(x) worked before ...
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #441 +/- ##
=======================================
Coverage 98.82% 98.82%
=======================================
Files 28 28
Lines 2034 2035 +1
Branches 356 356
=======================================
+ Hits 2010 2011 +1
Misses 2 2
Partials 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiki-tempula
approved these changes
Oct 21, 2025
|
Thanks for the quick review @xiki-tempula ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local type checker
is happy again.