Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update toml_edit to 0.24, toml to 0.9.10 #8814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chrisduerr merged 2 commits into from
Jan 14, 2026
Merged

Update toml_edit to 0.24, toml to 0.9.10 #8814

chrisduerr merged 2 commits into from
Jan 14, 2026

Conversation

@musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented Jan 14, 2026

Version 0.24.0 of toml_edit adds support for TOML 1.1: https://diff.rs/toml_edit/0.23.10+spec-1.0.0/0.24.0+spec-1.1.0/Cargo.toml/

As a logical companion, set the minimum version of toml to 0.9.10, the first release that supported TOML 1.1.

I confirmed that cargo test --workspace still passes.

chrisduerr
chrisduerr requested changes Jan 14, 2026
View reviewed changes
Copy link
Member

@chrisduerr chrisduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a logical companion, set the minimum version of toml to 0.9.10, the first release that supported TOML 1.1.

Did you actually test it against 0.9.10? You can't assume that compatibility with 0.9.11 means compatibility with 0.9.10.

This also needs a changelog entry.

@musicinmybrain
Copy link
Contributor Author

musicinmybrain commented Jan 14, 2026

As a logical companion, set the minimum version of toml to 0.9.10, the first release that supported TOML 1.1.

Did you actually test it against 0.9.10? You can't assume that compatibility with 0.9.11 means compatibility with 0.9.10.

I tested updating toml_edit alone and leaving toml at 0.9.2, then I tested it with toml 0.9.11. I didn’t test 0.9.10 specifically. (In each case, testing means running cargo test --workspace.)

I suppose there’s no reason not to just ask for toml 0.9.11. I’ll do that.

This also needs a changelog entry.

Added.

chrisduerr
chrisduerr reviewed Jan 14, 2026
View reviewed changes
Cargo.lock
Comment on lines 2006 to +2007
name = "toml_edit"
version = "0.23.6"
version = "0.23.10+spec-1.0.0"
Copy link
Member

@chrisduerr chrisduerr Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for personal reference: This is pulled by winit through android-activity and ndk. Since these dependencies are only used on Android, it shouldn't affect us.

@chrisduerr chrisduerr merged commit 08134af into alacritty:master Jan 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisduerr chrisduerr chrisduerr approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@musicinmybrain @chrisduerr