Conversation
added 2 commits
May 11, 2023 20:37
7 tasks
Codecov Report
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 67.66% 69.05% +1.39%
==========================================
Files 32 36 +4
Lines 1976 2414 +438
==========================================
+ Hits 1337 1667 +330
- Misses 570 654 +84
- Partials 69 93 +24
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tzaffi
commented
May 15, 2023
tzaffi
commented
May 15, 2023
| "txn.apap": true, | ||
| "txn.apsu": true, | ||
| "dt.lg": true, | ||
| "dt.sa": true, |
Contributor
Author
There was a problem hiding this comment.
Cannot handle this slice type EvalDelta.SharedAccounts
Eric-Warehime
approved these changes
May 15, 2023
algochoi
reviewed
May 15, 2023
Contributor
algochoi
left a comment
There was a problem hiding this comment.
Looks good to go after changing the Go SDK hash
added 2 commits
May 15, 2023 13:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle type update and pass indexer E2E tests
This PR results from fixing the type inconsistency for
EvalDeltaingo-algorand-sdk(algorand/go-algorand-sdk#531) and passing the failing nightly test in indexer.NOTE:
This should not be merged until algorand/go-algorand-sdk#531 is merged and the
go.modin this project is updated.