Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Generalize goreleaser config.#93

Merged
winder merged 2 commits intoalgorand:masterfrom
winder:will/goreleaser-env
Jun 13, 2023
Merged

Generalize goreleaser config.#93
winder merged 2 commits intoalgorand:masterfrom
winder:will/goreleaser-env

Conversation

@winder
Copy link
Contributor

@winder winder commented Jun 8, 2023

Summary

These changes make it easier to borrow the goreleaser configuration for child projects.

  • A single environment variable names the docker images.
  • The LDFlags and binary definitions are grouped together.

Test Plan

Manually running goreleaser.

@winder winder self-assigned this Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #93 (8068cef) into master (442791a) will increase coverage by 1.65%.
The diff coverage is 73.95%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   67.66%   69.31%   +1.65%     
==========================================
  Files          32       36       +4     
  Lines        1976     2428     +452     
==========================================
+ Hits         1337     1683     +346     
- Misses        570      653      +83     
- Partials       69       92      +23     
Impacted Files Coverage Δ
conduit/data/block_export_data.go 100.00% <ø> (+92.30%) ⬆️
conduit/plugins/importers/algod/metrics.go 100.00% <ø> (ø)
...plugins/processors/filterprocessor/gen/generate.go 34.28% <ø> (ø)
pkg/cli/internal/list/list.go 20.75% <ø> (ø)
...lugins/exporters/postgresql/postgresql_exporter.go 66.66% <51.21%> (-11.54%) ⬇️
pkg/cli/cli.go 65.97% <65.97%> (ø)
conduit/pipeline/pipeline.go 66.26% <71.12%> (+0.80%) ⬆️
conduit/data/config.go 76.47% <76.47%> (ø)
conduit/plugins/importers/algod/algod_importer.go 88.34% <87.06%> (+0.03%) ⬆️
conduit/pipeline/errors.go 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@winder winder marked this pull request as ready for review June 9, 2023 17:05
@winder winder requested a review from a team June 12, 2023 16:41
@winder winder merged commit 4c59abc into algorand:master Jun 13, 2023
@winder winder deleted the will/goreleaser-env branch June 13, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants