Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Apr 10, 2019. It is now read-only.

Conversation

@lhecker
Copy link
Contributor

@lhecker lhecker commented Oct 10, 2016

The previous code used regular expressions in the form of ^(?P<path>[^:]+):... to match the path in the linter output. A regexp like that doesn't work on Windows though, where paths are in the C:\foo\bar.go format. I thus changed all regexp strings to use the pattern from predefinedPatterns, which seems to work well enough. Due to this the "metalinter" ignored the output of half of all invoked linters.

I also applied some other minor changes to the regexps in general to make them more uniform.

@alecthomas
Copy link
Owner

Excellent, thanks! Fixes #130 and #157.

@alecthomas alecthomas merged commit 8f44796 into alecthomas:master Oct 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants