This repository was archived by the owner on Apr 10, 2019. It is now read-only.
Fixed regexp matching for Windows paths #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code used regular expressions in the form of
^(?P<path>[^:]+):...to match the path in the linter output. A regexp like that doesn't work on Windows though, where paths are in theC:\foo\bar.goformat. I thus changed all regexp strings to use the pattern frompredefinedPatterns, which seems to work well enough. Due to this the "metalinter" ignored the output of half of all invoked linters.I also applied some other minor changes to the regexps in general to make them more uniform.