Fix future IPFS Pinning regression on postgres based Nodes #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing a new helper to copy informations from an `origin` array to a `destination` array, when both array have a common key (ex: an `item_hash`). Greatly enhances performance by transforming a double array lookup into an hashmap lookup. https://jsben.ch/N5BI6
|
Deployed (not pinned) on https://ipfs-2.aleph.im/ipfs/QmSruiJphhBAmJDDbxC6kLhaTQEMrWtZ2TvgK8268FrPrj |
Member
Author
|
To test it locally you may replace the default API server with a known postgres-based API. |
hoh
reviewed
Jan 31, 2023
Member
hoh
left a comment
There was a problem hiding this comment.
I am confused with the computations on the size of files.
The interface mentions GB (Gigabytes), but is it in fact computing GiB (Gibibytes) ?
The size variables do not carry any information on the unit, which is quite confusing.
hoh
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to fix a regression that will occur when the PostgreSQL API is live on pyaleph.
STOREmessage won't display file size anymore. To solve this issues, file sizes will be fetched on a separate endpoint and merged at display.This PR has no effect when using the current API
Source and additional context
Here is the same store message on current API and a Node using the new postgresql implementation:
Notice that the
sizekey is missing on the latter. To fix this, we use the new/api/v0/addresses/filesendpoint to retrieve the missing information.Misc. fix
It also fixes the way the current
usedspace is calculated, it was previously computed on client side, by summing the size of store message posted on thePINNINGchannel, this had several caveat (ie.: the used space relied on the number of fetched items). It is now directly returned by the API on/api/v0/addresses/files