Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CRNtable, sort_by keys, autofiltering on reward_add/qemu/coco #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olethanh merged 6 commits into from
Aug 26, 2024
Merged

Fix CRNtable, sort_by keys, autofiltering on reward_add/qemu/coco #259

olethanh merged 6 commits into from
Aug 26, 2024

Conversation

@philogicae
Copy link
Member

@philogicae philogicae commented Aug 22, 2024 •
edited
Loading

image

Changes

  • Cleaning / rewritting / simplification of commands -> instance -> display.py / network.py
  • Properly retrieve CRN data
  • Fix broken CRNTable
  • Add sort_by keys (score, name, version, address, coco, qemu, url)
  • Add auto-filtering for reward address, qemu support and confidential support

How to test

Try to create a PAYG or coco instance without specifying crn_hash and crn_url. It will display the new CRNTable.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.
  • Documentation has been updated regarding these changes.

@github-actions
Copy link

github-actions bot commented Aug 22, 2024

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@philogicae philogicae force-pushed the fix-crn-table-clean branch from 95d8084 to 2052f50 Compare August 22, 2024 17:06
@philogicae philogicae changed the title Fix CRNtable + Add filtering for cocos + Add sort_by Fix CRNtable, sort_by keys, autofiltering on reward_add/qemu/coco Aug 22, 2024
@philogicae philogicae requested review from 1yam and olethanh August 22, 2024 17:26
@philogicae philogicae self-assigned this Aug 22, 2024
@philogicae philogicae force-pushed the fix-crn-table-clean branch from 2609013 to 9f8dc7b Compare August 25, 2024 19:12
@philogicae philogicae force-pushed the fix-crn-table-clean branch from 9f8dc7b to f6be97d Compare August 25, 2024 19:50
olethanh
olethanh approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@olethanh olethanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice it make things a lot smoother.

Only thing I'm not sure is that the 🔒 is clear enough to indicate that this is for confidentials. Maybe in the action menu we could put "Sort By 🔒 Confidential" ?

olethanh
olethanh reviewed Aug 26, 2024
View reviewed changes
@codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 29.04564% with 171 lines in your changes missing coverage. Please review.

Project coverage is 38.62%. Comparing base (995e737) to head (00f6476).
Report is 1 commits behind head on master.

Files Patch % Lines
src/aleph_client/commands/instance/display.py 27.83% 69 Missing and 1 partial ⚠️
src/aleph_client/commands/instance/__init__.py 4.34% 66 Missing ⚠️
src/aleph_client/models.py 47.50% 21 Missing ⚠️
src/aleph_client/commands/instance/network.py 65.21% 7 Missing and 1 partial ⚠️
src/aleph_client/utils.py 33.33% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   38.47%   38.62%   +0.14%     
==========================================
  Files          18       18              
  Lines        1788     1820      +32     
  Branches      303      310       +7     
==========================================
+ Hits          688      703      +15     
- Misses       1081     1097      +16     
- Partials       19       20       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olethanh olethanh merged commit 740b156 into master Aug 26, 2024
@philogicae philogicae deleted the fix-crn-table-clean branch August 26, 2024 14:30
@Psycojoker Psycojoker mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olethanh olethanh olethanh approved these changes

@1yam 1yam Awaiting requested review from 1yam

Assignees

@philogicae philogicae

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philogicae @olethanh