Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hoh
Copy link
Member

@hoh hoh commented Mar 4, 2025

The command aleph account create did not permit users to import their private key encoded in base32 or base64.

This adds the --key-format argument to the command to specify this.

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.42%. Comparing base (ed3dc8b) to head (39b73ba).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/account.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #350   +/-   ##
=======================================
  Coverage   61.41%   61.42%           
=======================================
  Files          18       18           
  Lines        3167     3183   +16     
  Branches      445      448    +3     
=======================================
+ Hits         1945     1955   +10     
- Misses        985      990    +5     
- Partials      237      238    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The command `aleph account create` did not permit users to import their private key encoded in base32 or base64.

This adds the `--key-format` argument to the command to specify this.
@hoh hoh force-pushed the hoh-key-import-format branch from 5759392 to 39b73ba Compare March 4, 2025 12:35
@github-actions
Copy link

github-actions bot commented Mar 4, 2025

Failed to retrieve llama text: POST 500: Traceback (most recent call last):
File "/root/init1.py", line 406, in process_instruction
headers, body, output, output_data = await run_executable_http(
File "/root/init1.py", line 342, in run_executable_http
headers, body = await make_request(session, scope)
File "/root/init1.py", line 311, in make_request
async with session.request(
File "/usr/local/lib/python3.9/dist-packages/aiohttp/client.py", line 1141, in aenter
self._resp = await self._coro
File "/usr/local/lib/python3.9/dist-packages/aiohttp/client.py", line 560, in _request
await resp.start(conn)
File "/usr/local/lib/python3.9/dist-packages/aiohttp/client_reqrep.py", line 914, in start
self._continue = None
File "/usr/local/lib/python3.9/dist-packages/aiohttp/helpers.py", line 721, in exit
raise asyncio.TimeoutError from None
asyncio.exceptions.TimeoutError

@hoh hoh requested a review from Psycojoker March 5, 2025 15:40
Copy link
Collaborator

@Psycojoker Psycojoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, that's a nice addition!

@hoh hoh merged commit 7deb39f into master Mar 6, 2025
14 checks passed
@Psycojoker Psycojoker deleted the hoh-key-import-format branch March 6, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants