Fix: Estimated cost based on TX and not hardcoded value #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesitor
approved these changes
Apr 8, 2025
937bb7c to
3548b53
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 60.81% 60.59% -0.22%
==========================================
Files 20 19 -1
Lines 3718 3586 -132
Branches 524 511 -13
==========================================
- Hits 2261 2173 -88
+ Misses 1192 1151 -41
+ Partials 265 262 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9abd6fa to
aff8dad
Compare
…ed InsufficientFundsError)
9fdba57 to
3124499
Compare
nesitor
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mostly simplify the logic on instance delete using error hadnling change in PR
Related ClickUp, GitHub or Jira tickets : ALEPH-496
Self proofreading checklist
Changes
This pull request includes updates to dependencies and error handling improvements in the
deletefunction. The most important changes are listed below:Dependency Updates:
aleph-sdk-pythondependency to a specific branch1yam-fix-estimated-gasinpyproject.toml. (This need to be revert since it depends on it)Error Handling Improvements:
InsufficientFundsErrorin thedeletefunction insrc/aleph_client/commands/instance/__init__.py.How to test
Explain how to test your PR.
This PR can be tested by using empty wallet with not enough gas / aleph otken
Notes
No change is made on instance create for UX reason we keep the pre check early.