-
Notifications
You must be signed in to change notification settings - Fork 15
Feature: Port forwarding #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
==========================================
- Coverage 61.64% 60.91% -0.73%
==========================================
Files 19 20 +1
Lines 3379 3718 +339
Branches 473 524 +51
==========================================
+ Hits 2083 2265 +182
- Misses 1055 1184 +129
- Partials 241 269 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nesitor
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implement Port Forwarding and also simplify some heavy logic is now on SDK side,
This also refactor the UI parts of
aleph instance listto have his own class to build the UIRelated ClickUp, GitHub or Jira tickets : ALEPH-XXX
Self proofreading checklist
Documentation
The documentation regarding the impacted features is available on:
The changes in the documentation are available here:
Changes
This pull request introduces several updates to the Aleph client, focusing on enhancing instance management, port forwarding capabilities, and simplifying code. Key changes include adding support for port forwarding, improving instance deletion logic, and simplifying the
list_instancescommand to leverage new utility methods.Instance Management Enhancements:
list_instancescommand to use utility methods for fetching instances and allocations, removing manual filtering and processing logic.Port Forwarding Features:
port-forwarderto manage port forwarding for instances.Codebase Simplification:
src/aleph_client/commands/instance/__init__.pyandsrc/aleph_client/commands/instance/network.py. [1] [2] [3]Dependency Updates:
aleph-sdk-pythondependency to a new branch for improved network support.Help Strings:
How to test
Print screen / video
Notes
Things that the reviewers should know: known bugs that are out of the scope of the PR, other trade-offs that were made.
If the PR depends on a PR in another repo, or merges into another PR (i.o. main), it should also be mentioned here