Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix: Wrap all command args in Annotated #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philogicae merged 1 commit into from
Feb 18, 2025
Merged

Fix: Wrap all command args in Annotated #339

philogicae merged 1 commit into from
Feb 18, 2025

Conversation

@philogicae
Copy link
Member

@philogicae philogicae commented Feb 18, 2025

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Changes

  • Wrap all command args in Annotated to allow to easily import CLI as a lib

@philogicae philogicae changed the title annotated: node cmds Wrap all command args in Annotated Feb 18, 2025
@codecov
Copy link

codecov bot commented Feb 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.56%. Comparing base (c0c4476) to head (73cafae).

Additional details and impacted files 
@@                      Coverage Diff                      @@
##           feat-new-pricing-and-flow     #339      +/-   ##
=============================================================
+ Coverage                      57.50%   58.56%   +1.06%     
=============================================================
  Files                             18       18              
  Lines                           3113     3113              
  Branches                         430      430              
=============================================================
+ Hits                            1790     1823      +33     
+ Misses                          1104     1067      -37     
- Partials                         219      223       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae marked this pull request as ready for review February 18, 2025 14:25
@aleph-im aleph-im deleted a comment from github-actions bot Feb 18, 2025
@philogicae philogicae changed the title Wrap all command args in Annotated Fix: Wrap all command args in Annotated Feb 18, 2025
@philogicae philogicae self-assigned this Feb 18, 2025
@philogicae philogicae changed the base branch from feat-new-pricing-and-flow to master February 18, 2025 17:29
@philogicae philogicae merged commit 41575ac into master Feb 18, 2025
12 checks passed
@philogicae philogicae deleted the fix-annotated-args branch February 18, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nesitor nesitor nesitor approved these changes

Assignees

@philogicae philogicae

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philogicae @nesitor