Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nesitor
Copy link
Member

@nesitor nesitor commented Sep 9, 2025

Fix: Solve issue for building the package on MacOs.

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Changes

Remove macos tap specification installing the required library.

How to test

Check that CI macos step passes.

@nesitor nesitor requested a review from 1yam September 9, 2025 15:08
@nesitor nesitor self-assigned this Sep 9, 2025
@nesitor nesitor force-pushed the andres-fix-solve_macos_CI_issue branch from f6e7e1e to 85e764e Compare September 9, 2025 15:10
@nesitor nesitor marked this pull request as ready for review September 9, 2025 15:14
@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.81%. Comparing base (50fb1c5) to head (85e764e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #401   +/-   ##
=======================================
  Coverage   60.81%   60.81%           
=======================================
  Files          20       20           
  Lines        3718     3718           
  Branches      524      524           
=======================================
  Hits         2261     2261           
  Misses       1192     1192           
  Partials      265      265           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleph-im aleph-im deleted a comment from github-actions bot Sep 9, 2025
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nesitor nesitor merged commit 30375f1 into master Sep 9, 2025
15 checks passed
@nesitor nesitor deleted the andres-fix-solve_macos_CI_issue branch September 9, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants