Implement allocation resource check #852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
559d2cc to
0180fcc
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
+ Coverage 65.24% 65.36% +0.11%
==========================================
Files 88 88
Lines 8515 8578 +63
Branches 756 765 +9
==========================================
+ Hits 5556 5607 +51
- Misses 2724 2733 +9
- Partials 235 238 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f2d7b37 to
21bc76d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Implement resource checks before allocating a VM.
Related ClickUp, GitHub or Jira tickets : ALEPH-764
Self proofreading checklist
packaging/MakefileChanges
Added a filter before VM creation that checks if the CRN have enough resource available to allocate the VM. If not returns an error message telling why cannot allocate it.
How to test
Try to create a big instance inside a CRN with not enough available resources, it should show an error before trying to allocate.