Added balance pre-check on file pins #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pre-check on STORE messages before doing the message processing.
…efore downloading it, only in IPFS case.
…placed by the new one `verify_message`.
0f142b9 to
8cfe2b1
Compare
amalcaraz
requested changes
May 29, 2025
Collaborator
amalcaraz
left a comment
There was a problem hiding this comment.
I think there could be a problem calculating real costs for ProgramContent DATA volume
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue when a user tries to pin a big file on IPFS without having a balance.
Self proofreading checklist
Changes
Added a pre-check balance checking the IPFS file without having to download it. It will work only on unifs type pins, but will save us a lot of useless disk usage.
How to test
Try to pin a big file on the network with an empty wallet and check that file is not saved either on the database and the message is rejected so faster.