Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tailo
Copy link

@tailo tailo commented Jun 20, 2016

Hi. Great project. I have added some functionality I needed

  • Owin hosting
  • Be able to run and control out of proc. (Driven from the need to run our nightly integration tests from our build server)

It still needs a good cleanup and a bit of a restructure ( as well as a few more unit tests). I will hopefully get to that in the next couple of weeks but in the meantime I wanted to see if you were interested in this functionality coming into your project?

@alexvictoor
Copy link
Owner

Hello
Sure, I am interested by your contribution!
However I have 2 requests:
-please split your PRs in order to ease the review. For example if you think we should change the visibility of some classes, you can send a dedicated PR on this topic.

  • I would like the core module to be dependency free. Owin related classes should be located in their own module, this way mock4net users will get own assemblies only when needed.
    Cheers

Alex

@StefH
Copy link

StefH commented Jan 17, 2017

@tailo

AppVeyor fails on Could not resolve this reference. Could not locate the assembly "Newtonsoft.Json, Version=8.0.0.0

Can you add another change to your PR to use the latest version Newtonsoft.Json 8 ?

@alexvictoor
Copy link
Owner

@tailo no news from you since my last comment :(

@tailo
Copy link
Author

tailo commented Jan 17, 2017 via email

@alexvictoor
Copy link
Owner

Congratulations!
I'll wait next month then :)

@StefH
Copy link

StefH commented Jan 19, 2017

About the failing appveyor ; I think you need to add

before_build:
- nuget restore

somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants