Add AWS Spot Placement Scores support #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add score.go with AWS EC2 spot placement score integration - Extend types.go with score-related data structures - Add comprehensive types_test.go with score functionality tests - Implements region and AZ-level score fetching with timeout handling
- Update client.go with score enrichment capability - Add comprehensive client_test.go coverage for score features - Regenerate mocks_test.go for new scoring interfaces - Enables score filtering, sorting, and regional/AZ-level fetching
- Add --with-score, --min-score, --az, --score-timeout flags - Implement color-coded score display (🟢/🔴 indicators) - Add score sorting and filtering in CLI interface - Update tests for new scoring command-line functionality
- Update MCP tools to support score parameters and filtering - Add score enrichment to MCP tool responses - Refactor and streamline MCP test coverage - Enable score features in Model Context Protocol interface
- Add aws-spot-placement-scores.md with detailed API documentation - Update usage.md with score filtering examples and CLI options - Extend examples.md with score-based use cases and scenarios - Update mcp-server.md with score parameter documentation - Enhance data-sources.md and api-reference.md for score features
- Update go.mod/go.sum with AWS SDK dependencies for score API - Enhance .golangci.yaml with additional linting rules - Update .mockery.yaml for new scoring interfaces - Ensure compatibility with score enrichment dependencies
- Add score feature overview and benefits section - Include score CLI examples and usage scenarios - Document score filtering, sorting, and visualization features - Streamline README structure with focus on core functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive AWS Spot Placement Scores support, enabling users to make more informed decisions when selecting spot instances based on AWS's proprietary placement reliability scores.
🚀 New Features
--min-scoreflag to filter instances by reliability threshold--azflag--sort scoreoption for reliability-based ranking--score-timeoutfor API response control🎯 Key Benefits
📊 CLI Examples
🔧 Technical Implementation
internal/spot/score.go- AWS API integration with error handling📚 Documentation
docs/aws-spot-placement-scores.md- Complete API documentationdocs/usage.mdanddocs/examples.md- Practical scenariosdocs/mcp-server.md- Protocol-specific documentationec2:GetSpotPlacementScoresIAM permission🧪 Test Coverage
Test Plan