Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented May 16, 2024

This is just a hotfix for #186. I will need to talk to Felix for the full fix.

@wiseodd wiseodd added the bug Something isn't working label May 16, 2024
@wiseodd wiseodd added this to the 0.2 milestone May 16, 2024
@wiseodd wiseodd requested a review from runame May 16, 2024 15:54
@wiseodd wiseodd self-assigned this May 16, 2024
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine for now.

@wiseodd
Copy link
Collaborator Author

wiseodd commented Jun 11, 2024

TODO: Compute Jacobians with the "best" backend during prediction, not necessarily the one used for computing the Hessian in fit. I.e. we should think of the Jacobian (in the GLM predictive) as separate, backend-wise, from the Hessian.

Edit: Should be a separate PR!

@wiseodd wiseodd merged commit 2aade44 into main Jun 13, 2024
@wiseodd wiseodd deleted the native-jacobians branch June 13, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants