Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@aleximmer
Copy link
Owner

Changes:

  • make mean a quantity that falls back to prior when not yet fit and is set on .fit() so that .log_prob() is correct
  • add log_prob(value) to compute log density under LA for regularization. This falls back to prior before fitting the LA
  • add .fit(train_loader, override=True) where override means to reset Hessian approximation while override == False leads to adding up curvature, e.g., for continual learning

@aleximmer aleximmer requested a review from runame December 7, 2021 18:41
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this really simplifies continual learning! I wrote a few minor comments.

Optional, probably not needed:

  • Test repeated fit for last-layer Laplace
  • Test initialization of mean and precision to prior

@runame runame added the enhancement New feature or request label Dec 10, 2021
@runame runame added this to the NeurIPS Prerelease milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants