feat: add support for nrf54l15 in mpsl and sdc #85
+965
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lulf
commented
Nov 4, 2025
- Support configuring MPSL interrupts for nrf54l
- Support configuring SDC for nrf54l
- Add nrf54l-specific checks and initialization in MPSL
- Generalize critical-section-impl to work with larger interrupt vectors
- Add support for running the adv-simple example on the nrf54l15-dk
* Support configuring MPSL interrupts for nrf54l * Support configuring SDC for nrf54l * Add nrf54l-specific checks and initialization in MPSL * Generalize critical-section-impl to work with larger interrupt vectors * Add support for running the adv-simple example on the nrf54l15-dk
Collaborator
Author
|
Not super happy about the comment duplication in mpsl.rs for the different struct definitions, but code wise it feels easier to read/understand when it's grouped like this. |
alexmoon
reviewed
Nov 5, 2025
Owner
alexmoon
left a comment
There was a problem hiding this comment.
Looks good to me. I get what you mean about the repeated comments, but I think this approach is probably best.
Comment on lines
+32
to
+38
| embassy-executor = {git = "https://github.com/embassy-rs/embassy.git", rev="dda429ce6642deaa490f8737e1373e2e2ba79655"} | ||
| embassy-nrf = {git = "https://github.com/embassy-rs/embassy.git", rev="dda429ce6642deaa490f8737e1373e2e2ba79655"} | ||
| embassy-sync = {git = "https://github.com/embassy-rs/embassy.git", rev="dda429ce6642deaa490f8737e1373e2e2ba79655"} | ||
| embassy-futures = {git = "https://github.com/embassy-rs/embassy.git", rev="dda429ce6642deaa490f8737e1373e2e2ba79655"} | ||
| embassy-time = {git = "https://github.com/embassy-rs/embassy.git", rev="dda429ce6642deaa490f8737e1373e2e2ba79655"} | ||
| embassy-time-driver = {git = "https://github.com/embassy-rs/embassy.git", rev="dda429ce6642deaa490f8737e1373e2e2ba79655"} | ||
| embassy-embedded-hal = {git = "https://github.com/embassy-rs/embassy.git", rev="dda429ce6642deaa490f8737e1373e2e2ba79655"} |
Owner
There was a problem hiding this comment.
We need to stick with the crates.io versions in order to publish, are these overrides needed?
Collaborator
Author
There was a problem hiding this comment.
It is meant as a temporary measure, I would like to wait a little with releasing the embassy crates until the nrf54 stuff has received a bit more testing.
HaoboGu
reviewed
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.