Always check linecache #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
This ensures that
Source.for_filenamealways callslinecache.checkcacheso that outdated entries are purged and theSourcereflects the latest content of the file. It's more robust than #45 as it doesn't depend onsys.meta_pathor even modules being reloaded.Code elsewhere that pops entries from
__source_cacheis no longer needed, but is harmless and will keep things working with older versions of executing.If
linecache.checkcacheremoves an entry andlinecache.getlinesdoesn't create a new one, then the original is restored. This means that code which directly inserts entries intolinecache.cacheto avoid the file system is still safe fromlinecache.checkcacheaggressively removing entries for fake filenames.