-
Notifications
You must be signed in to change notification settings - Fork 8
Fix #61: Put 'auto ref' storage classes adjacent #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before, DMD 2.111.0 produced twice the following deprecation warning: "Deprecation: `auto` and `ref` storage classes should be adjacent" https://dlang.org/changelog/2.111.0.html#dmd.auto-ref-put-adjacent Now, package optional builds warning-free and deprecation-free with the recently released DMD 2.111.0.
aliak00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow! I'm so out of D and its ecosystem now. This looks perfectly fine - but I have no idea how to release a new version anymore 😆 - let's hope I figure it out :P
|
Thanks for the quick merge! |
Dub documentation about publishing says:
|
|
Ooh that sounded easy enough. Tried that just now 🤞 Btw @SimonN - would you like to take this over if I just gave you access so you can fix whatever you need to and push and merge and all that jazz? :p I do not see myself getting into this anytime soon given my current status/situation! |
|
It looks like the dub package registry updater hasn't found the tag yet. Package optional on the registry is still at v1.3.0. From looking at your past releases, a lightweight tag should be enough. The updater saw the v1.3.0 lightweight tag from 4 years ago, therefore it should see your v1.3.1 lightweight tag, too. I asked in the D IRC channel (
Thanks for your trust and the offer of successorship! That would be my first dub package to maintain. I'll sleep over it a few days, and come back to you with an answer. |
|
Yes, that was it; the package registry has the 1.3.1 now. Thanks! (The dub site happens to be down today, but I saw the 1.3.1 correctly there earlier.) I've decided: Yes, I'm happy to become maintainer of the optional package. I have an active client project (Lix) that uses optional, therefore I see the occasional breakage in optional early. I've submitted PRs to optional like this one, and yesterday, I've dug into the details of the dub packaging/versioning process. I don't have an account on the dub package registry, but I'll be busy this weekend. I'll open an account there in 0-3 weeks. I haven't published API documentation web pages yet. I'm interested in better type/functor/monad support in D itself, but I won't invest much time to push such an issue with D directly. |
|
Awesome! I've added you to this repo now, so I think you can do whatever you want. If there're any issues then feel free to just ping back here. Let me know if I have to do anything in DUB to "permit" the transfer there or anything so you can just release whenever you want to too! |
|
I guess if it's just about pushing a tag, the opening account account is not strictly necessary, but it would be convenient to click the buttons I had to click yesterday or whatever to force pickup a tag release :D |
|
All right, thanks! I'll let you know when I make an account for the dub package registry. |
Before, DMD 2.111.0 produced twice the following deprecation warning: "Deprecation:
autoandrefstorage classes should be adjacent"https://dlang.org/changelog/2.111.0.html#dmd.auto-ref-put-adjacent
Now, package optional builds warning-free and deprecation-free with the recently released DMD 2.111.0.