add betterC support #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ooh the beginnings of betterC support 😍 I'm not very familiar with betterC support and what exactly it entails, does this alone make this fully betterC compliant? If not then how much work do you think it would additionally take? I tried running the unittests (just the ones in It just throws an error: No stack trace or anything to say where it's coming from. |
Contributor
Author
|
This small change made it fully compatible with betterC. I was surprised as well :) You are using features in your unittest that don't work in betterC, so you'll get errors there. But it doesn't matter. Thanks for the quick merge! |
Owner
|
Cool! and no probs. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added betterC support simply by disabling the toString method of Optional(T).