More resources can be added.Adjust the resource limit by csp.sentinel.context.max.size #2109
Conversation
….context.max.size
| if (maxContextNameSize < 0) { | ||
| maxContextNameSize = DEFAULT_MAX_CONTEXT_NAME_SIZE; | ||
| } |
There was a problem hiding this comment.
Maybe log a warning message here to tell the user that we had overwritten the maxContextNameSize value
There was a problem hiding this comment.
I need a standard warning message
| } catch (Exception ex) { | ||
| maxContextNameSize = DEFAULT_MAX_CONTEXT_NAME_SIZE; | ||
| } |
There was a problem hiding this comment.
log an error message here?
There was a problem hiding this comment.
In fact, I wrote it with reference to the resolveAppType method. There is no warning message in the resolveAppType method
|
|
||
| private static int maxContextNameSize = DEFAULT_MAX_CONTEXT_NAME_SIZE; | ||
|
|
There was a problem hiding this comment.
I think we should name it maxContextSize
There was a problem hiding this comment.
It named MAX_CONTEXT_NAME_SIZE in com.alibaba.csp.sentinel.Constants
|
|
|
Due to this PR's inactivity and the unsigned CLA, we are temporarily closing it. Feel free to create a new PR if you still intend to contribute after addressing the CLA requirement. |
Describe what this PR does / why we need it
当资源数大于2000时限流不可用
Does this pull request fix one issue?
Fixed #2108
Describe how you did it
Describe how to verify it
编写相关测试
Special notes for reviews
@sczyh30